
* improve interoperability with rclcpp::Duration and std::chrono Signed-off-by: William Woodall <william@osrfoundation.org> * add to_rmw_time to Duration Signed-off-by: William Woodall <william@osrfoundation.org> * add new QoS class to rclcpp Signed-off-by: William Woodall <william@osrfoundation.org> * changes to NodeBase, NodeTopics, etc in preparation for changes to pub/sub Signed-off-by: William Woodall <william@osrfoundation.org> * refactor publisher creation to use new QoS class Signed-off-by: William Woodall <william@osrfoundation.org> * refactor subscription creation to use new QoS class Signed-off-by: William Woodall <william@osrfoundation.org> * fixing fallout from changes to pub/sub creation Signed-off-by: William Woodall <william@osrfoundation.org> * fixed Windows error: no appropriate default constructor available why? who knows Signed-off-by: William Woodall <william@osrfoundation.org> * fixed Windows error: could not deduce template argument for 'PublisherT' Signed-off-by: William Woodall <william@osrfoundation.org> * fix missing vftable linker error on Windows Signed-off-by: William Woodall <william@osrfoundation.org> * fix more cases of no suitable default constructor errors... Signed-off-by: William Woodall <william@osrfoundation.org> * prevent msvc from trying to interpret some cases as functions Signed-off-by: William Woodall <william@osrfoundation.org> * uncrustify Signed-off-by: William Woodall <william@osrfoundation.org> * cpplint Signed-off-by: William Woodall <william@osrfoundation.org> * add C++ version of default action qos Signed-off-by: William Woodall <william@osrfoundation.org> * fixing lifecycle subscription signatures Signed-off-by: William Woodall <william@osrfoundation.org> * fix allocators (we actually use this already in the pub/sub factory) Signed-off-by: William Woodall <william@osrfoundation.org> * suppress cppcheck on false positive syntax error Signed-off-by: William Woodall <william@osrfoundation.org> * fix more cppcheck syntax error false positives Signed-off-by: William Woodall <william@osrfoundation.org> * fix case where sub-type of QoS is used Signed-off-by: William Woodall <william@osrfoundation.org> * fixup get_node_topics_interface.hpp according to reviews and tests Signed-off-by: William Woodall <william@osrfoundation.org> * additional fixes based on local testing and CI Signed-off-by: William Woodall <william@osrfoundation.org> * another trick to avoid 'no appropriate default constructor available' Signed-off-by: William Woodall <william@osrfoundation.org> * fix compiler error with clang on macOS Signed-off-by: William Woodall <william@osrfoundation.org> * disable build failure tests until we can get Jenkins to ignore their output Signed-off-by: William Woodall <william@osrfoundation.org> * suppress more cppcheck false positives Signed-off-by: William Woodall <william@osrfoundation.org> * add missing visibility macros to default QoS profile classes Signed-off-by: William Woodall <william@osrfoundation.org> * fix another case of 'no appropriate default constructor available' Signed-off-by: William Woodall <william@osrfoundation.org> * unfortunately this actaully fixes a build error on Windows... Signed-off-by: William Woodall <william@osrfoundation.org> * fix typos Signed-off-by: William Woodall <william@osrfoundation.org>
224 lines
8 KiB
C++
224 lines
8 KiB
C++
// Copyright 2015 Open Source Robotics Foundation, Inc.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
|
|
#include <gtest/gtest.h>
|
|
#include <memory>
|
|
#include <string>
|
|
#include <utility>
|
|
|
|
#include "lifecycle_msgs/msg/state.hpp"
|
|
#include "lifecycle_msgs/msg/transition.hpp"
|
|
|
|
#include "rclcpp/rclcpp.hpp"
|
|
#include "rclcpp_lifecycle/lifecycle_node.hpp"
|
|
|
|
using lifecycle_msgs::msg::State;
|
|
using lifecycle_msgs::msg::Transition;
|
|
|
|
class TestDefaultStateMachine : public ::testing::Test
|
|
{
|
|
protected:
|
|
static void SetUpTestCase()
|
|
{
|
|
rclcpp::init(0, nullptr);
|
|
}
|
|
};
|
|
|
|
class EmptyLifecycleNode : public rclcpp_lifecycle::LifecycleNode
|
|
{
|
|
public:
|
|
explicit EmptyLifecycleNode(std::string node_name)
|
|
: rclcpp_lifecycle::LifecycleNode(std::move(node_name))
|
|
{}
|
|
};
|
|
|
|
struct GoodMood
|
|
{
|
|
using CallbackReturnT =
|
|
rclcpp_lifecycle::node_interfaces::LifecycleNodeInterface::CallbackReturn;
|
|
static constexpr CallbackReturnT cb_ret = static_cast<CallbackReturnT>(
|
|
lifecycle_msgs::msg::Transition::TRANSITION_CALLBACK_SUCCESS);
|
|
};
|
|
struct BadMood
|
|
{
|
|
using CallbackReturnT =
|
|
rclcpp_lifecycle::node_interfaces::LifecycleNodeInterface::CallbackReturn;
|
|
static constexpr CallbackReturnT cb_ret = static_cast<CallbackReturnT>(
|
|
lifecycle_msgs::msg::Transition::TRANSITION_CALLBACK_FAILURE);
|
|
};
|
|
|
|
template<class Mood = GoodMood>
|
|
class MoodyLifecycleNode : public rclcpp_lifecycle::LifecycleNode
|
|
{
|
|
public:
|
|
explicit MoodyLifecycleNode(std::string node_name)
|
|
: rclcpp_lifecycle::LifecycleNode(std::move(node_name))
|
|
{}
|
|
|
|
size_t number_of_callbacks = 0;
|
|
|
|
protected:
|
|
rclcpp_lifecycle::node_interfaces::LifecycleNodeInterface::CallbackReturn
|
|
on_configure(const rclcpp_lifecycle::State &)
|
|
{
|
|
EXPECT_EQ(State::TRANSITION_STATE_CONFIGURING, get_current_state().id());
|
|
++number_of_callbacks;
|
|
return Mood::cb_ret;
|
|
}
|
|
|
|
rclcpp_lifecycle::node_interfaces::LifecycleNodeInterface::CallbackReturn
|
|
on_activate(const rclcpp_lifecycle::State &)
|
|
{
|
|
EXPECT_EQ(State::TRANSITION_STATE_ACTIVATING, get_current_state().id());
|
|
++number_of_callbacks;
|
|
return Mood::cb_ret;
|
|
}
|
|
|
|
rclcpp_lifecycle::node_interfaces::LifecycleNodeInterface::CallbackReturn
|
|
on_deactivate(const rclcpp_lifecycle::State &)
|
|
{
|
|
EXPECT_EQ(State::TRANSITION_STATE_DEACTIVATING, get_current_state().id());
|
|
++number_of_callbacks;
|
|
return Mood::cb_ret;
|
|
}
|
|
|
|
rclcpp_lifecycle::node_interfaces::LifecycleNodeInterface::CallbackReturn
|
|
on_cleanup(const rclcpp_lifecycle::State &)
|
|
{
|
|
EXPECT_EQ(State::TRANSITION_STATE_CLEANINGUP, get_current_state().id());
|
|
++number_of_callbacks;
|
|
return Mood::cb_ret;
|
|
}
|
|
|
|
rclcpp_lifecycle::node_interfaces::LifecycleNodeInterface::CallbackReturn
|
|
on_shutdown(const rclcpp_lifecycle::State &)
|
|
{
|
|
EXPECT_EQ(State::TRANSITION_STATE_SHUTTINGDOWN, get_current_state().id());
|
|
++number_of_callbacks;
|
|
return Mood::cb_ret;
|
|
}
|
|
|
|
rclcpp_lifecycle::node_interfaces::LifecycleNodeInterface::CallbackReturn
|
|
on_error(const rclcpp_lifecycle::State &);
|
|
};
|
|
|
|
template<>
|
|
rclcpp_lifecycle::node_interfaces::LifecycleNodeInterface::CallbackReturn
|
|
MoodyLifecycleNode<GoodMood>::on_error(const rclcpp_lifecycle::State &)
|
|
{
|
|
EXPECT_EQ(State::TRANSITION_STATE_ERRORPROCESSING, get_current_state().id());
|
|
ADD_FAILURE();
|
|
return rclcpp_lifecycle::node_interfaces::LifecycleNodeInterface::CallbackReturn::SUCCESS;
|
|
}
|
|
|
|
template<>
|
|
rclcpp_lifecycle::node_interfaces::LifecycleNodeInterface::CallbackReturn
|
|
MoodyLifecycleNode<BadMood>::on_error(const rclcpp_lifecycle::State &)
|
|
{
|
|
EXPECT_EQ(State::TRANSITION_STATE_ERRORPROCESSING, get_current_state().id());
|
|
++number_of_callbacks;
|
|
return rclcpp_lifecycle::node_interfaces::LifecycleNodeInterface::CallbackReturn::SUCCESS;
|
|
}
|
|
|
|
TEST_F(TestDefaultStateMachine, empty_initializer) {
|
|
auto test_node = std::make_shared<EmptyLifecycleNode>("testnode");
|
|
EXPECT_STREQ("testnode", test_node->get_name());
|
|
EXPECT_STREQ("/", test_node->get_namespace());
|
|
EXPECT_EQ(State::PRIMARY_STATE_UNCONFIGURED, test_node->get_current_state().id());
|
|
}
|
|
|
|
TEST_F(TestDefaultStateMachine, trigger_transition) {
|
|
auto test_node = std::make_shared<EmptyLifecycleNode>("testnode");
|
|
|
|
EXPECT_EQ(State::PRIMARY_STATE_UNCONFIGURED, test_node->get_current_state().id());
|
|
ASSERT_EQ(State::PRIMARY_STATE_INACTIVE, test_node->trigger_transition(
|
|
rclcpp_lifecycle::Transition(Transition::TRANSITION_CONFIGURE)).id());
|
|
ASSERT_EQ(State::PRIMARY_STATE_ACTIVE, test_node->trigger_transition(
|
|
rclcpp_lifecycle::Transition(Transition::TRANSITION_ACTIVATE)).id());
|
|
ASSERT_EQ(State::PRIMARY_STATE_INACTIVE, test_node->trigger_transition(
|
|
rclcpp_lifecycle::Transition(Transition::TRANSITION_DEACTIVATE)).id());
|
|
ASSERT_EQ(State::PRIMARY_STATE_UNCONFIGURED, test_node->trigger_transition(
|
|
rclcpp_lifecycle::Transition(Transition::TRANSITION_CLEANUP)).id());
|
|
ASSERT_EQ(State::PRIMARY_STATE_FINALIZED, test_node->trigger_transition(
|
|
rclcpp_lifecycle::Transition(Transition::TRANSITION_UNCONFIGURED_SHUTDOWN)).id());
|
|
}
|
|
|
|
TEST_F(TestDefaultStateMachine, trigger_transition_with_error_code) {
|
|
auto test_node = std::make_shared<EmptyLifecycleNode>("testnode");
|
|
|
|
auto success = rclcpp_lifecycle::node_interfaces::LifecycleNodeInterface::CallbackReturn::SUCCESS;
|
|
auto reset_key = rclcpp_lifecycle::node_interfaces::LifecycleNodeInterface::CallbackReturn::ERROR;
|
|
auto ret = reset_key;
|
|
|
|
test_node->configure(ret);
|
|
|
|
EXPECT_EQ(success, ret);
|
|
ret = reset_key;
|
|
|
|
test_node->activate(ret);
|
|
EXPECT_EQ(success, ret);
|
|
ret = reset_key;
|
|
|
|
test_node->deactivate(ret);
|
|
EXPECT_EQ(success, ret);
|
|
ret = reset_key;
|
|
|
|
test_node->cleanup(ret);
|
|
EXPECT_EQ(success, ret);
|
|
ret = reset_key;
|
|
|
|
test_node->shutdown(ret);
|
|
EXPECT_EQ(success, ret);
|
|
}
|
|
|
|
TEST_F(TestDefaultStateMachine, good_mood) {
|
|
auto test_node = std::make_shared<MoodyLifecycleNode<GoodMood>>("testnode");
|
|
|
|
EXPECT_EQ(State::PRIMARY_STATE_UNCONFIGURED, test_node->get_current_state().id());
|
|
EXPECT_EQ(State::PRIMARY_STATE_INACTIVE, test_node->trigger_transition(
|
|
rclcpp_lifecycle::Transition(Transition::TRANSITION_CONFIGURE)).id());
|
|
EXPECT_EQ(State::PRIMARY_STATE_ACTIVE, test_node->trigger_transition(
|
|
rclcpp_lifecycle::Transition(Transition::TRANSITION_ACTIVATE)).id());
|
|
EXPECT_EQ(State::PRIMARY_STATE_INACTIVE, test_node->trigger_transition(
|
|
rclcpp_lifecycle::Transition(Transition::TRANSITION_DEACTIVATE)).id());
|
|
EXPECT_EQ(State::PRIMARY_STATE_UNCONFIGURED, test_node->trigger_transition(
|
|
rclcpp_lifecycle::Transition(Transition::TRANSITION_CLEANUP)).id());
|
|
EXPECT_EQ(State::PRIMARY_STATE_FINALIZED, test_node->trigger_transition(
|
|
rclcpp_lifecycle::Transition(Transition::TRANSITION_UNCONFIGURED_SHUTDOWN)).id());
|
|
|
|
// check if all callbacks were successfully overwritten
|
|
EXPECT_EQ(5u, test_node->number_of_callbacks);
|
|
}
|
|
|
|
TEST_F(TestDefaultStateMachine, bad_mood) {
|
|
auto test_node = std::make_shared<MoodyLifecycleNode<BadMood>>("testnode");
|
|
|
|
EXPECT_EQ(State::PRIMARY_STATE_UNCONFIGURED, test_node->get_current_state().id());
|
|
EXPECT_EQ(State::PRIMARY_STATE_UNCONFIGURED, test_node->trigger_transition(
|
|
rclcpp_lifecycle::Transition(Transition::TRANSITION_CONFIGURE)).id());
|
|
|
|
// check if all callbacks were successfully overwritten
|
|
EXPECT_EQ(1u, test_node->number_of_callbacks);
|
|
}
|
|
|
|
TEST_F(TestDefaultStateMachine, lifecycle_subscriber) {
|
|
auto test_node = std::make_shared<MoodyLifecycleNode<GoodMood>>("testnode");
|
|
|
|
auto cb = [](const std::shared_ptr<lifecycle_msgs::msg::State> msg) {(void) msg;};
|
|
auto lifecycle_sub =
|
|
test_node->create_subscription<lifecycle_msgs::msg::State>("~/empty", 10, cb);
|
|
|
|
SUCCEED();
|
|
}
|