rclcpp/rclcpp_action/include/rclcpp_action
Jacob Perron c7b62bff71
[rclcpp_action] Action client holds weak pointers to goal handles (#1122)
* [rclcpp_action] Action client holds weak pointers to goal handles

Fixes #861

It is against the design of ROS actions to rely on the status topic for the core implementation,
instead it should just be used for introspection.

Rather than relying on the status topic to remove references to goal handles, the action client
instead holds weak pointers to the goal handles. This way as long as a user holds a reference to
the goal handle they can use it to interact with the action client.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

* Move cleanup logic to the end of the function

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

* Add TODO

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

* Log debug messages when dropping a weak references to goal handles

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

* Improve documentation

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
2020-05-22 11:41:34 -07:00
..
client.hpp [rclcpp_action] Action client holds weak pointers to goal handles (#1122) 2020-05-22 11:41:34 -07:00
client_goal_handle.hpp Deprecate ClientGoalHandle::async_result() (#1120) 2020-05-21 11:39:07 -07:00
client_goal_handle_impl.hpp Deprecate ClientGoalHandle::async_result() (#1120) 2020-05-21 11:39:07 -07:00
create_client.hpp deprecate redundant namespaces (#1083) 2020-04-23 15:28:45 -07:00
create_server.hpp deprecate redundant namespaces (#1083) 2020-04-23 15:28:45 -07:00
exceptions.hpp Fix UnknownGoalHandle error string. (#856) 2019-09-18 17:52:49 -04:00
qos.hpp change API to encourage users to specify history depth always (#713) 2019-05-08 14:24:40 -07:00
rclcpp_action.hpp Add documentation to rclcpp_action 2019-03-12 11:56:18 -07:00
server.hpp rename rosidl_generator_c namespace to rosidl_runtime_c (#1062) 2020-04-10 21:58:22 -07:00
server_goal_handle.hpp Rename action state transitions (#677) 2019-04-16 04:46:40 -07:00
types.hpp update to use separated action types (#601) 2019-03-11 21:12:47 -07:00
visibility_control.hpp Skeleton for Action Server and Client (#579) 2018-11-21 09:16:51 -08:00