niklas/rclcpp
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Make sure the Waitable class has a virtual destructor.

Browse source 
Noticed while reviewing this issue.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
This commit is contained in:
Chris Lalancette 2020-05-27 21:56:11 +00:00 • committed by Chris Lalancette
parent 5632fa03ae
commit c9c4253c84
1 changed files with 3 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

3
rclcpp/include/rclcpp/waitable.hpp
View file

@ -30,6 +30,9 @@ class Waitable
public: public:
RCLCPP_SMART_PTR_DEFINITIONS_NOT_COPYABLE(Waitable) RCLCPP_SMART_PTR_DEFINITIONS_NOT_COPYABLE(Waitable)
RCLCPP_PUBLIC
virtual ~Waitable() = default;
/// Get the number of ready subscriptions /// Get the number of ready subscriptions
/** /**
* Returns a value of 0 by default. * Returns a value of 0 by default.