niklas/rclcpp
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Further expand test tolerance to address flakiness. (#501)

Browse source 
* Further expand test tolerance to address flakiness.

* Remove newline.
This commit is contained in:
Michael Carroll 2018-06-19 13:06:30 -05:00 • committed by GitHub
parent 62c8c5b762
commit bf89dc0797
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

9
rclcpp/test/executors/test_multi_threaded_executor.cpp
View file

@ -71,8 +71,11 @@ TEST_F(TestMultiThreadedExecutor, timer_over_take) {
std::atomic_int timer_count {0}; std::atomic_int timer_count {0};
auto timer_callback = [&timer_count, &executor, &system_clock, &last_mutex, &last]() { auto timer_callback = [&timer_count, &executor, &system_clock, &last_mutex, &last]() {
// While this tolerance is a little wide, if the bug occurs, the next step will
// happen almost instantly. The purpose of this test is not to measure the jitter
// in timers, just assert that a reasonable amount of time has passed.
const double PERIOD = 0.1f; const double PERIOD = 0.1f;
const double TOLERANCE = 0.01f; const double TOLERANCE = 0.025f;
rclcpp::Time now = system_clock.now(); rclcpp::Time now = system_clock.now();
timer_count++; timer_count++;
@ -88,8 +91,8 @@ TEST_F(TestMultiThreadedExecutor, timer_over_take) {
if (diff < PERIOD - TOLERANCE || diff > PERIOD + TOLERANCE) { if (diff < PERIOD - TOLERANCE || diff > PERIOD + TOLERANCE) {
executor.cancel(); executor.cancel();
ASSERT_TRUE(diff > PERIOD - TOLERANCE); ASSERT_GT(diff, PERIOD - TOLERANCE);
ASSERT_TRUE(diff < PERIOD + TOLERANCE); ASSERT_LT(diff, PERIOD + TOLERANCE);
} }
} }
}; };