niklas/rclcpp
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Increase coverage of guard_condition.cpp to 100% (#1369)

Browse source 
Signed-off-by: Stephen Brawner <brawner@gmail.com>
This commit is contained in:
brawner 2020-10-01 13:10:07 -07:00
parent 17c53a16f0
commit b3f50460f4
2 changed files with 19 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
rclcpp/test/CMakeLists.txt
View file

@ -567,7 +567,7 @@ endif()
ament_add_gtest(test_guard_condition rclcpp/test_guard_condition.cpp ament_add_gtest(test_guard_condition rclcpp/test_guard_condition.cpp
APPEND_LIBRARY_DIRS "${append_library_dirs}") APPEND_LIBRARY_DIRS "${append_library_dirs}")
if(TARGET test_guard_condition) if(TARGET test_guard_condition)
target_link_libraries(test_guard_condition ${PROJECT_NAME}) target_link_libraries(test_guard_condition ${PROJECT_NAME} mimick)
endif() endif()
ament_add_gtest(test_wait_set rclcpp/test_wait_set.cpp ament_add_gtest(test_wait_set rclcpp/test_wait_set.cpp

19
rclcpp/test/rclcpp/test_guard_condition.cpp
View file

@ -18,6 +18,8 @@
#include "rclcpp/rclcpp.hpp" #include "rclcpp/rclcpp.hpp"
#include "../mocking_utils/patch.hpp"
class TestGuardCondition : public ::testing::Test class TestGuardCondition : public ::testing::Test
{ {
protected: protected:
@ -54,6 +56,14 @@ TEST_F(TestGuardCondition, construction_and_destruction) {
(void)gc; (void)gc;
}, rclcpp::exceptions::RCLInvalidArgument); }, rclcpp::exceptions::RCLInvalidArgument);
} }
{
auto mock = mocking_utils::inject_on_return(
"lib:rclcpp", rcl_guard_condition_fini, RCL_RET_ERROR);
auto gc = std::make_shared<rclcpp::GuardCondition>();
// This just logs an error on destruction
EXPECT_NO_THROW(gc.reset());
}
} }
/* /*
@ -82,6 +92,13 @@ TEST_F(TestGuardCondition, get_rcl_guard_condition) {
TEST_F(TestGuardCondition, trigger) { TEST_F(TestGuardCondition, trigger) {
{ {
auto gc = std::make_shared<rclcpp::GuardCondition>(); auto gc = std::make_shared<rclcpp::GuardCondition>();
gc->trigger(); EXPECT_NO_THROW(gc->trigger());
{
auto mock = mocking_utils::patch_and_return(
"lib:rclcpp", rcl_trigger_guard_condition, RCL_RET_ERROR);
auto gc = std::make_shared<rclcpp::GuardCondition>();
EXPECT_THROW(gc->trigger(), rclcpp::exceptions::RCLError);
}
} }
} }