niklas/rclcpp
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

pass strings as const reference

Browse source
This commit is contained in:
Dirk Thomas 2015-07-16 22:30:16 -07:00
parent bdafa54d8b
commit 76c41bb048
2 changed files with 8 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

8
rclcpp/include/rclcpp/node.hpp
View file

@ -102,9 +102,9 @@ public:
RCLCPP_MAKE_SHARED_DEFINITIONS(Node); RCLCPP_MAKE_SHARED_DEFINITIONS(Node);
/* Create a node based on the node name. */ /* Create a node based on the node name. */
Node(std::string node_name); Node(const std::string & node_name);
/* Create a node based on the node name and a rclcpp::context::Context. */ /* Create a node based on the node name and a rclcpp::context::Context. */
Node(std::string node_name, rclcpp::context::Context::SharedPtr context); Node(const std::string & node_name, rclcpp::context::Context::SharedPtr context);
/* Get the name of the node. */ /* Get the name of the node. */
const std::string & const std::string &
@ -117,13 +117,13 @@ public:
/* Create and return a Publisher. */ /* Create and return a Publisher. */
template<typename MessageT> template<typename MessageT>
rclcpp::publisher::Publisher::SharedPtr rclcpp::publisher::Publisher::SharedPtr
create_publisher(std::string topic_name, size_t queue_size); create_publisher(const std::string & topic_name, size_t queue_size);
/* Create and return a Subscription. */ /* Create and return a Subscription. */
template<typename MessageT> template<typename MessageT>
typename rclcpp::subscription::Subscription<MessageT>::SharedPtr typename rclcpp::subscription::Subscription<MessageT>::SharedPtr
create_subscription( create_subscription(
std::string topic_name, const std::string & topic_name,
size_t queue_size, size_t queue_size,
std::function<void(const std::shared_ptr<MessageT> &)> callback, std::function<void(const std::shared_ptr<MessageT> &)> callback,
rclcpp::callback_group::CallbackGroup::SharedPtr group = nullptr, rclcpp::callback_group::CallbackGroup::SharedPtr group = nullptr,

8
rclcpp/include/rclcpp/node_impl.hpp
View file

@ -38,11 +38,11 @@ using namespace rclcpp::node;
using rclcpp::contexts::default_context::DefaultContext; using rclcpp::contexts::default_context::DefaultContext;
Node::Node(std::string node_name) Node::Node(const std::string & node_name)
: Node(node_name, DefaultContext::make_shared()) : Node(node_name, DefaultContext::make_shared())
{} {}
Node::Node(std::string node_name, context::Context::SharedPtr context) Node::Node(const std::string & node_name, context::Context::SharedPtr context)
: name_(node_name), context_(context), : name_(node_name), context_(context),
number_of_subscriptions_(0), number_of_timers_(0), number_of_services_(0) number_of_subscriptions_(0), number_of_timers_(0), number_of_services_(0)
{ {
@ -89,7 +89,7 @@ Node::create_callback_group(
template<typename MessageT> template<typename MessageT>
publisher::Publisher::SharedPtr publisher::Publisher::SharedPtr
Node::create_publisher(std::string topic_name, size_t queue_size) Node::create_publisher(const std::string & topic_name, size_t queue_size)
{ {
using rosidl_generator_cpp::get_message_type_support_handle; using rosidl_generator_cpp::get_message_type_support_handle;
auto type_support_handle = get_message_type_support_handle<MessageT>(); auto type_support_handle = get_message_type_support_handle<MessageT>();
@ -122,7 +122,7 @@ Node::group_in_node(callback_group::CallbackGroup::SharedPtr & group)
template<typename MessageT> template<typename MessageT>
typename subscription::Subscription<MessageT>::SharedPtr typename subscription::Subscription<MessageT>::SharedPtr
Node::create_subscription( Node::create_subscription(
std::string topic_name, const std::string & topic_name,
size_t queue_size, size_t queue_size,
std::function<void(const std::shared_ptr<MessageT> &)> callback, std::function<void(const std::shared_ptr<MessageT> &)> callback,
rclcpp::callback_group::CallbackGroup::SharedPtr group, rclcpp::callback_group::CallbackGroup::SharedPtr group,