niklas/rclcpp
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Use -Wpedantic (#306)

Browse source 
* add /W4 flag for windows

* use uint8 like defined in messages: fix warning C4244

* fix sign size_t comparison

* add only pedantic, not W4, deal with windows another day

* another sign compare warning
This commit is contained in:
Mikael Arguedas 2017-02-27 21:07:57 -08:00 • committed by GitHub
parent ce146cfdba
commit 71f5b7fe5b
10 changed files with 45 additions and 43 deletions
Download patch file Download diff file Expand all files Collapse all files

2
rclcpp_lifecycle/include/rclcpp_lifecycle/lifecycle_node.hpp
View file

@ -356,7 +356,7 @@ public:
RCLCPP_LIFECYCLE_PUBLIC
const State &
trigger_transition(unsigned int transition_id);
trigger_transition(uint8_t transition_id);
RCLCPP_LIFECYCLE_PUBLIC
bool

4
rclcpp_lifecycle/include/rclcpp_lifecycle/state.hpp
View file

@ -32,7 +32,7 @@ public:
State();
RCLCPP_LIFECYCLE_PUBLIC
State(unsigned int id, const std::string & label);
State(uint8_t id, const std::string & label);
RCLCPP_LIFECYCLE_PUBLIC
explicit State(const rcl_lifecycle_state_t * rcl_lifecycle_state_handle);
@ -41,7 +41,7 @@ public:
virtual ~State();
RCLCPP_LIFECYCLE_PUBLIC
unsigned int
uint8_t
id() const;
RCLCPP_LIFECYCLE_PUBLIC

6
rclcpp_lifecycle/include/rclcpp_lifecycle/transition.hpp
View file

@ -33,11 +33,11 @@ public:
Transition() = delete;
RCLCPP_LIFECYCLE_PUBLIC
explicit Transition(unsigned int id, const std::string & label = "");
explicit Transition(uint8_t id, const std::string & label = "");
RCLCPP_LIFECYCLE_PUBLIC
Transition(
unsigned int id, const std::string & label,
uint8_t id, const std::string & label,
State && start, State && goal);
RCLCPP_LIFECYCLE_PUBLIC
@ -47,7 +47,7 @@ public:
virtual ~Transition();
RCLCPP_LIFECYCLE_PUBLIC
unsigned int
uint8_t
id() const;
RCLCPP_LIFECYCLE_PUBLIC