niklas/rclcpp
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

replace 'auto' to 'const auto &' (#630)

Browse source 
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
This commit is contained in:
Yutaka Kondo 2019-02-13 11:02:29 +09:00 • committed by William Woodall
parent 4046563de6
commit 10d7b7c72b
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
rclcpp/src/rclcpp/node_interfaces/node_parameters.cpp
View file

@ -177,7 +177,7 @@ NodeParameters::set_parameters(
const std::vector<rclcpp::Parameter> & parameters) const std::vector<rclcpp::Parameter> & parameters)
{ {
std::vector<rcl_interfaces::msg::SetParametersResult> results; std::vector<rcl_interfaces::msg::SetParametersResult> results;
for (auto p : parameters) { for (const auto & p : parameters) {
auto result = set_parameters_atomically({{p}}); auto result = set_parameters_atomically({{p}});
results.push_back(result); results.push_back(result);
} }
@ -206,7 +206,7 @@ NodeParameters::set_parameters_atomically(
return result; return result;
} }
for (auto p : parameters) { for (const auto & p : parameters) {
if (p.get_type() == rclcpp::ParameterType::PARAMETER_NOT_SET) { if (p.get_type() == rclcpp::ParameterType::PARAMETER_NOT_SET) {
if (parameters_.find(p.get_name()) != parameters_.end()) { if (parameters_.find(p.get_name()) != parameters_.end()) {
// case: parameter was set before, and input is "NOT_SET" // case: parameter was set before, and input is "NOT_SET"
@ -229,7 +229,7 @@ NodeParameters::set_parameters_atomically(
tmp_map.insert(parameters_.begin(), parameters_.end()); tmp_map.insert(parameters_.begin(), parameters_.end());
// remove explicitly deleted parameters // remove explicitly deleted parameters
for (auto p : parameters) { for (const auto & p : parameters) {
if (p.get_type() == rclcpp::ParameterType::PARAMETER_NOT_SET) { if (p.get_type() == rclcpp::ParameterType::PARAMETER_NOT_SET) {
tmp_map.erase(p.get_name()); tmp_map.erase(p.get_name());
} }