niklas/rclcpp
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

I realize why the original was spelled wrong, volatile is a c++ keyword. Modify to not require learning a misspelling, and note why it can't have that name (#725)

Browse source 
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
This commit is contained in:
Emerson Knapp 2019-05-17 18:18:58 -07:00 • committed by Dirk Thomas
parent 05c19028f4
commit 005131dba8
2 changed files with 5 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
rclcpp/include/rclcpp/qos.hpp
View file

@ -105,8 +105,11 @@ public:
durability(rmw_qos_durability_policy_t durability); durability(rmw_qos_durability_policy_t durability);
/// Set the durability setting to volatile. /// Set the durability setting to volatile.
/**
* Note that this cannot be named `volatile` because it is a C++ keyword.
*/
QoS & QoS &
volatile(); durability_volatile();
/// Set the durability setting to transient local. /// Set the durability setting to transient local.
QoS & QoS &

2
rclcpp/src/rclcpp/qos.cpp
View file

@ -120,7 +120,7 @@ QoS::durability(rmw_qos_durability_policy_t durability)
} }
QoS & QoS &
QoS::volatile() QoS::durability_volatile()
{ {
return this->durability(RMW_QOS_POLICY_DURABILITY_VOLATILE); return this->durability(RMW_QOS_POLICY_DURABILITY_VOLATILE);
} }