niklas/cyclonedds
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
357 commits 1 branch 0 tags 9.9 MiB
Commit graph

215 commits

Author SHA1 Message Date
Erik Boasson
27913be1c3 Fix memory leak in function to clear all writer address sets 
Signed-off-by: Erik Boasson <eb@ilities.com>
 2019-01-02 12:13:40 +01:00
Erik Boasson
0b814df584 Use sizeof(sin_addr) in IPv4 address compare instead of effectively sizeof(size_t) 
Signed-off-by: Erik Boasson <eb@ilities.com>
 2019-01-02 12:13:40 +01:00
Erik Boasson
d6306bddbb Properly handle "incompatible if unrecognized" in parameter lists (#79) 
Previously it would fall through and assert in a debug build or return an error in a release build. The behaviour in a release build was almost correct, as the flag means the entity should be completely ignored if the parameter is not understood by the implementation, but I don't believe it should result in a warning — certainly not that claims the parameter list is invalid. A specific return code is now used to indicate a parameter list that was rejected because of this flag, and that suppresses the warning.

Signed-off-by: Erik Boasson <eb@ilities.com>
 2019-01-02 12:13:40 +01:00
Erik Boasson
e0d5587639 Unified key-to-iid map means a backref to the map is no longer needed 
Signed-off-by: Erik Boasson <eb@ilities.com>
 2019-01-02 12:13:40 +01:00
Erik Boasson
781c644800 participants are not hidden built-in entities in built-in topics and should get an instance handle consistent with the DCPSParticipant topic 
Signed-off-by: Erik Boasson <erik.boasson@prismtech.com>
 2019-01-01 18:52:27 +01:00
Erik Boasson
179a35d192 fix race conditions in instance id-to-key lookup 
this is just an intermediate step: firstly, iid-to-key lookup is a linear scan; secondly, the lookup should happen on the RHC or the WHC and not on some internal map to associates key values with instance handles and is independent of entities

Signed-off-by: Erik Boasson <eb@ilities.com>
 2018-12-25 12:40:05 +01:00
Erik Boasson
0f7ce1ac43 instance operations must also ensure thread is considered awake or GC may free tkmap instances prematurely 
Signed-off-by: Erik Boasson <eb@ilities.com>
 2018-12-25 12:40:05 +01:00
Erik Boasson
84506b8518 rollback changes to dispose counts when resource limits reached during RHC update 
Signed-off-by: Erik Boasson <eb@ilities.com>
 2018-12-25 12:40:05 +01:00
Erik Boasson
e96a47f3f9 fix test issues detected by address sanitizer 
Signed-off-by: Erik Boasson <eb@ilities.com>
 2018-12-25 12:40:05 +01:00
Erik Boasson
98c53db057 fix leak of config data if a domain id problem leads to an initialization failure 
Signed-off-by: Erik Boasson <eb@ilities.com>
 2018-12-25 12:40:05 +01:00
eboasson
97c5e06b6a
Merge pull request #69 from FirasSahliADLinktech/rename-functions 
Make function names more consistent:

* ``dds_topic_{get,set}_filter`` -> ``dds_{get,set}_topic_filter``
* ``dds_{get,set}_enabled_status`` -> ``dds_{get,set}_status_mask``
* ``dds_instance_lookup`` -> ``dds_lookup_instance``

Plus removal of defunct ddsv2.h.
 2018-12-25 12:38:25 +01:00
Erik Boasson
1a0fcea0c2 replace old builtin topics by new ones and add implementation of DCPSSubscription and DCPSPublication 
Signed-off-by: Erik Boasson <eb@ilities.com>
 2018-12-14 14:02:08 +01:00
Erik Boasson
78d49b52a0 add new "builtin topic" types and conversion routines 
Signed-off-by: Erik Boasson <eb@ilities.com>
 2018-12-14 14:02:08 +01:00
Erik Boasson
945fc94de7 setting "must inspect result" on return_loan is pedantry 
Signed-off-by: Erik Boasson <eb@ilities.com>
 2018-12-14 14:02:08 +01:00
Erik Boasson
e631567c35 extend sertopic interface and move the concept of a type descriptor to just the sertopic definition 
Signed-off-by: Erik Boasson <eb@ilities.com>
 2018-12-14 14:02:08 +01:00
Erik Boasson
c169df6227 fix refcount leak of tkmap instances when copying transient-local history from a local writer 
Signed-off-by: Erik Boasson <eb@ilities.com>
 2018-12-14 14:02:08 +01:00
Erik Boasson
ef65101ad7 pushing released serdata:s onto a freelist was dropped by accident in the rewriting of them 
Signed-off-by: Erik Boasson <eb@ilities.com>
 2018-12-14 14:02:08 +01:00
Erik Boasson
29f542b916 iid and tkmap are integral to this DDSI stack and should be part of it 
They were made available from the DCPS layer to DDSI using some function pointers, but it makes more sense to have them as part of the DDSI core.

Signed-off-by: Erik Boasson <eb@ilities.com>
 2018-12-14 14:02:08 +01:00
Firas Sahli
9f51f6f9dc
Rename get and set filter functions for topic 
Signed-off-by: Firas Sahli <firas.sahli@adlinktech.com>
 2018-12-11 11:07:09 +01:00
Firas Sahli
05f961dec1
Rename get and set of enabled status to mask 
Signed-off-by: Firas Sahli <firas.sahli@adlinktech.com>
 2018-12-11 11:07:09 +01:00
Firas Sahli
99f410bc49
Rename dds_instance_lookup to dds_lookup_instance 
Signed-off-by: Firas Sahli <firas.sahli@adlinktech.com>
 2018-12-11 11:06:50 +01:00
Firas Sahli
af7e34f143
Remove ddsv2.h 
Signed-off-by: Firas Sahli <firas.sahli@adlinktech.com>
 2018-12-11 11:06:27 +01:00
Jeroen Koekkoek
3c5a209389 Fix build warnings by passing a message to CU_PASS 
Signed-off-by: Jeroen Koekkoek <jeroen@koekkoek.nl>
 2018-12-10 13:05:59 +01:00
Jeroen Koekkoek
74a48c5731 Replace Criterion by CUnit 
Signed-off-by: Jeroen Koekkoek <jeroen@koekkoek.nl>
 2018-12-06 14:48:30 +01:00
Erik Boasson
e62abe623a fix warnings on qos function names and constness 
Signed-off-by: Erik Boasson <eb@ilities.com>
 2018-12-01 10:01:13 +01:00
Jeroen Koekkoek
1cf03332ca Simplify logging and remove unwanted functions from abstraction layer 
Signed-off-by: Jeroen Koekkoek <jeroen@koekkoek.nl>
 2018-11-30 23:42:19 +01:00
eboasson
69f563be5b
Merge pull request #60 from FirasSahliADLinktech/multiple_tests 
Some missing unit tests and correct signature
 2018-11-30 12:07:44 +01:00
Firas Sahli
6908e3deea
Correct signature and add tests for dds_instance_get_key 
Signed-off-by: Firas Sahli <firas.sahli@adlinktech.com>
 2018-11-28 10:52:14 +01:00
Firas Sahli
8aa6ceff81
Add test for dds_qos_copy and extra check to dds_qset_partition 
Signed-off-by: Firas Sahli <firas.sahli@adlinktech.com>
 2018-11-28 10:41:24 +01:00
Firas Sahli
4b627fd9aa
Add simple test for dds_time 
Signed-off-by: Firas Sahli <firas.sahli@adlinktech.com>
 2018-11-28 10:38:07 +01:00
Erik Boasson
ec68eeac29 Bring listener operations naming scheme in line with the rest 
The main naming scheme is OPER_TYPE (i.e., dds_create_participant) but the listener operations were named TYPE_OPER (i.e., dds_listener_create). This commit brings the listener scheme in line with the rest, retaining the old names as a deprecated interface.

Signed-off-by: Erik Boasson <eb@ilities.com>
 2018-11-09 14:18:51 +01:00
Erik Boasson
651bdfee06 Bring QoS operations naming scheme in line with the rest 
The main naming scheme is OPER_TYPE (i.e., dds_create_participant) but the QoS operations were named TYPE_OPER (i.e., dds_qos_create). This commit brings the QoS scheme in line with the rest, retaining the old names as a deprecated interface.

Signed-off-by: Erik Boasson <eb@ilities.com>
 2018-11-09 14:18:47 +01:00
eboasson
2e2224daea
Merge pull request #31 from eboasson/builtintopics 
Refactor sample representation (along with a few small other details)
 2018-11-09 12:23:47 +01:00
Erik Boasson
8ba218dca8 dissociate WSAEvent from sockets handled on dedicated threads 
Signed-off-by: Erik Boasson <eb@ilities.com>
 2018-11-05 16:00:41 +01:00
Erik Boasson
4a4f4e22d1 dds_stream_extract_key: reserve space in destination before calling dds_stream_read_fixed_buffer 
Signed-off-by: Erik Boasson <eb@ilities.com>
 2018-10-29 21:37:06 +08:00
Erik Boasson
e3874c3c27 add some missing details in comments for serdata operations 
Signed-off-by: Erik Boasson <eb@ilities.com>
 2018-10-29 21:04:26 +08:00
Erik Boasson
b34cbdcf0c sockaddr_compare should really be ipaddr_compare 
Signed-off-by: Erik Boasson <eb@ilities.com>
 2018-10-29 13:38:16 +08:00
Erik Boasson
f2f436bde3 wrap indirect calls to WHC in inline functions 
Signed-off-by: Erik Boasson <eb@ilities.com>
 2018-10-29 13:28:19 +08:00
Erik Boasson
3e343d032a reduce dependency on sertopic->status_cb_entity 
Signed-off-by: Erik Boasson <eb@ilities.com>
 2018-10-29 13:26:24 +08:00
Erik Boasson
7cb80e7851 minor refactor of CDR-to-key/keyhash generation 
Signed-off-by: Erik Boasson <eb@ilities.com>
 2018-10-29 13:24:07 +08:00
Erik Boasson
259e4676dc fix sequencing of internal liveliness monitoring and rtps init/term 
liveliness monitoring requires rtps stack initialised if initially deaf, so starting the monitoring thread must happen after rtps_init

Signed-off-by: Erik Boasson <eb@ilities.com>
 2018-10-28 13:54:17 +08:00
Erik Boasson
9cab5e769c various interconnected changes for ddsi_serdata 
- topic-erased key-only serdata for use in tkmap
- restoration of including key values in invalid samples
- special handling of keyless topics
- keyhash generation via streams
- elimination of dynamically allocated buffers in keyhash
- removal of the last vestiges of "serstate"

Signed-off-by: Erik Boasson <eb@ilities.com>
 2018-10-28 13:31:23 +08:00
Erik Boasson
8e20ae547e avoid declaring an array on stack with non-constant size 
Signed-off-by: Erik Boasson <eb@ilities.com>
 2018-10-26 20:34:35 +08:00
Erik Boasson
fd931a2605 remove accidental return statement on the return of a void function 
Signed-off-by: Erik Boasson <eb@ilities.com>
 2018-10-26 20:32:47 +08:00
Erik Boasson
e841e4bf94 add back in the broken filter and query condition support 
the implementation was and is terrible, but without it too many tests fail

Signed-off-by: Erik Boasson <eb@ilities.com>
 2018-10-26 20:05:18 +08:00
Erik Boasson
791a0efe7e replace some implementation dependent types in protocol message specifications 
Signed-off-by: Erik Boasson <eb@ilities.com>
 2018-10-26 16:26:30 +08:00
Erik Boasson
a25f683bcf abstract the internal representation of a sample 
besides the old state being in dire need of cleaning up, this also paves the way for having any number of different sample representations in the system

Signed-off-by: Erik Boasson <eb@ilities.com>
 2018-10-26 16:25:26 +08:00
Jeroen Koekkoek
8fc9535316 Terminate address filter with OS_AF_NULL instead of 0 (AF_UNSPEC) 
Signed-off-by: Jeroen Koekkoek <jeroen@koekkoek.nl>
 2018-10-24 22:32:27 +02:00
Jeroen Koekkoek
25198e565b Rename os_sockaddr_size to os_sockaddr_get_size for consitency 
Signed-off-by: Jeroen Koekkoek <jeroen@koekkoek.nl>
 2018-10-24 15:53:29 +02:00
Jeroen Koekkoek
6b41dada9d Fix compiler warnings 
Signed-off-by: Jeroen Koekkoek <jeroen@koekkoek.nl>
 2018-10-19 17:35:08 +02:00