niklas/cyclonedds
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix condition for validating topic access rules

Browse source 
Signed-off-by: Erik Boasson <eb@ilities.com>
This commit is contained in:
Erik Boasson 2020-02-24 13:11:52 +01:00 • committed by eboasson
parent b03195ec72
commit e0a9beb3cb
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/security/builtin_plugins/access_control/src/access_control_parser.c
View file

@ -419,7 +419,7 @@ static DDS_Security_boolean validate_rules(const struct domain_rule *rule, DDS_S
{ {
/* Last but not least, check the domain ids (ex is set when there's a failure) */ /* Last but not least, check the domain ids (ex is set when there's a failure) */
validate_domains(rule->domains->domain_id_set, ex); validate_domains(rule->domains->domain_id_set, ex);
if (!rule->topic_access_rules && rule->topic_access_rules->topic_rule) if (!(rule->topic_access_rules && rule->topic_access_rules->topic_rule))
DDS_Security_Exception_set(ex, DDS_ACCESS_CONTROL_PLUGIN_CONTEXT, DDS_SECURITY_ERR_IDENTITY_EMPTY_CODE, 0, "Found rule in Governance file without topic_access_rules"); DDS_Security_Exception_set(ex, DDS_ACCESS_CONTROL_PLUGIN_CONTEXT, DDS_SECURITY_ERR_IDENTITY_EMPTY_CODE, 0, "Found rule in Governance file without topic_access_rules");
else else
{ {