Remove dead stores triggering clang warnings

Signed-off-by: Erik Boasson <eb@ilities.com>

src/core/ddsc/src/dds_matched.c

@@ -144,8 +144,7 @@ static dds_builtintopic_endpoint_t *make_builtintopic_endpoint (const ddsi_guid_
 dds_builtintopic_endpoint_t *dds_get_matched_subscription_data (dds_entity_t writer, dds_instance_handle_t ih)
 {
   dds_writer *wr;
-  dds_return_t rc;
+  if (dds_writer_lock (writer, &wr))
-  if ((rc = dds_writer_lock (writer, &wr)) != DDS_RETCODE_OK)
     return NULL;
   else
   {
@@ -187,8 +186,7 @@ dds_builtintopic_endpoint_t *dds_get_matched_subscription_data (dds_entity_t wri
 dds_builtintopic_endpoint_t *dds_get_matched_publication_data (dds_entity_t reader, dds_instance_handle_t ih)
 {
   dds_reader *rd;
-  dds_return_t rc;
+  if (dds_reader_lock (reader, &rd))
-  if ((rc = dds_reader_lock (reader, &rd)) != DDS_RETCODE_OK)
     return NULL;
   else
   {

src/core/ddsc/src/dds_write.c

@@ -267,8 +267,7 @@ void dds_write_flush (dds_entity_t writer)
 {
   struct thread_state1 * const ts1 = lookup_thread_state ();
   dds_writer *wr;
-  dds_return_t rc;
+  if (dds_writer_lock (writer, &wr) == DDS_RETCODE_OK)
-  if ((rc = dds_writer_lock (writer, &wr)) == DDS_RETCODE_OK)
   {
     thread_state_awake (ts1, &wr->m_entity.m_domain->gv);
     nn_xpack_send (wr->m_xp, true);

src/core/ddsi/src/ddsi_mcgroup.c

@@ -203,7 +203,7 @@ static int joinleave_mcgroups (const struct ddsi_domaingv *gv, ddsi_tran_conn_t
         {
           if (gv->recvips_mode == RECVIPS_MODE_ALL || interface_in_recvips_p (gv->recvips, &gv->interfaces[i]))
           {
-            if ((rc = joinleave_mcgroup (conn, join, srcloc, mcloc, &gv->interfaces[i])) < 0)
+            if (joinleave_mcgroup (conn, join, srcloc, mcloc, &gv->interfaces[i]) < 0)
               fails++;
             else
               oks++;

src/core/ddsi/src/ddsi_security_omg.c

@@ -2250,7 +2250,6 @@ static bool q_omg_security_register_remote_writer_match(struct proxy_writer *pwr
   struct dds_security_context *sc = q_omg_security_get_secure_context(pp);
   DDS_Security_SecurityException exception = DDS_SECURITY_EXCEPTION_INIT;
   struct proxypp_pp_match *proxypp_match;
-  struct rd_pwr_match *match;
   bool send_tokens = false;
   bool allowed = false;
 
@@ -2258,7 +2257,7 @@ static bool q_omg_security_register_remote_writer_match(struct proxy_writer *pwr
     return false;
 
   ddsrt_mutex_lock(&rd->e.lock);
-  if ((match = ddsrt_avl_lookup (&rd_writers_treedef, &rd->writers, &pwr->e.guid)) != NULL)
+  if (ddsrt_avl_lookup (&rd_writers_treedef, &rd->writers, &pwr->e.guid) != NULL)
     allowed = true;
   else if (rd->e.guid.entityid.u == NN_ENTITYID_P2P_BUILTIN_PARTICIPANT_VOLATILE_SECURE_READER)
   {
@@ -2584,7 +2583,6 @@ static bool q_omg_security_register_remote_reader_match(struct proxy_reader *prd
   struct dds_security_context *sc = q_omg_security_get_secure_context(pp);
   DDS_Security_SecurityException exception = DDS_SECURITY_EXCEPTION_INIT;
   struct proxypp_pp_match *proxypp_match;
-  struct wr_prd_match *match;
   bool send_tokens = false;
   bool allowed = false;
 
@@ -2592,7 +2590,7 @@ static bool q_omg_security_register_remote_reader_match(struct proxy_reader *prd
     return false;
 
   ddsrt_mutex_lock(&wr->e.lock);
-  if ((match = ddsrt_avl_lookup (&wr_readers_treedef, &wr->readers, &prd->e.guid)) != NULL)
+  if (ddsrt_avl_lookup (&wr_readers_treedef, &wr->readers, &prd->e.guid) != NULL)
     allowed = true;
   else if (wr->e.guid.entityid.u == NN_ENTITYID_P2P_BUILTIN_PARTICIPANT_VOLATILE_SECURE_WRITER || !wr->sec_attr->attr.is_submessage_protected)
   {

src/core/ddsi/src/ddsi_udp.c

@@ -477,11 +477,11 @@ static dds_return_t ddsi_udp_create_conn (ddsi_tran_conn_t *conn_out, ddsi_tran_
     }
   }
 
-  if ((rc = set_rcvbuf (gv, sock, &gv->config.socket_min_rcvbuf_size)) != DDS_RETCODE_OK)
+  if (set_rcvbuf (gv, sock, &gv->config.socket_min_rcvbuf_size) != DDS_RETCODE_OK)
     goto fail_w_socket;
-  if ((rc = set_sndbuf (gv, sock, gv->config.socket_min_sndbuf_size)) != DDS_RETCODE_OK)
+  if (set_sndbuf (gv, sock, gv->config.socket_min_sndbuf_size) != DDS_RETCODE_OK)
     goto fail_w_socket;
-  if (gv->config.dontRoute && (rc = set_dont_route (gv, sock, ipv6)) != DDS_RETCODE_OK)
+  if (gv->config.dontRoute && set_dont_route (gv, sock, ipv6) != DDS_RETCODE_OK)
     goto fail_w_socket;
 
   if ((rc = ddsrt_bind (sock, &socketname.a, ddsrt_sockaddr_get_size (&socketname.a))) != DDS_RETCODE_OK)

src/core/ddsi/src/q_config.c

@@ -2246,14 +2246,13 @@ static int set_defaults (struct cfgst *cfgst, void *parent, int isattr, struct c
   int ok = 1;
   for (const struct cfgelem *ce = cfgelem; ce && ce->name; ce++)
   {
-    struct cfgst_node *n;
     struct cfgst_nodekey key;
     key.e = ce;
     key.p = parent;
     cfgst_push (cfgst, isattr, ce, parent);
     if (ce->multiplicity <= 1)
     {
-      if ((n = ddsrt_avl_lookup (&cfgst_found_treedef, &cfgst->found, &key)) == NULL)
+      if (ddsrt_avl_lookup (&cfgst_found_treedef, &cfgst->found, &key) == NULL)
       {
         if (ce->update)
         {

src/ddsrt/src/sync/posix/sync.c

@@ -159,22 +159,18 @@ ddsrt_cond_broadcast (ddsrt_cond_t *cond)
 void
 ddsrt_rwlock_init (ddsrt_rwlock_t *rwlock)
 {
-  int err = 0;
-
   assert(rwlock != NULL);
 
   /* process-shared attribute is set to PTHREAD_PROCESS_PRIVATE by default */
-  if ((err = pthread_rwlock_init(&rwlock->rwlock, NULL)) != 0)
+  if (pthread_rwlock_init(&rwlock->rwlock, NULL) != 0)
     abort();
 }
 
 void
 ddsrt_rwlock_destroy (ddsrt_rwlock_t *rwlock)
 {
-  int err;
-
   assert(rwlock != NULL);
-  if ((err = pthread_rwlock_destroy (&rwlock->rwlock)) != 0)
+  if (pthread_rwlock_destroy (&rwlock->rwlock) != 0)
     abort();
 }