niklas/cyclonedds
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix CID 304858 reported by Coverity Scan

Browse source 
Signed-off-by: Jeroen Koekkoek <jeroen@koekkoek.nl>
This commit is contained in:
Jeroen Koekkoek 2020-06-26 09:22:30 +02:00
parent 5d7f2fd438
commit 93c75186f0
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/tools/ddsconf/xsd.c
View file

@ -163,7 +163,7 @@ printref(
const char fmt[] = "<xs:element %s%sref=\"%s:%s\"/>\n"; const char fmt[] = "<xs:element %s%sref=\"%s:%s\"/>\n";
if (!(flags & FLAG_NOMIN) && minimum(elem) != 1) if (!(flags & FLAG_NOMIN) && minimum(elem) != 1)
snprintf(minattr, sizeof(minattr), "minOccurs=\"%d\" ", minimum(elem)); snprintf(minattr, sizeof(minattr), "minOccurs=\"%d\" ", minimum(elem));
if (!(flags & FLAG_NOMAX) &&maximum(elem) == 0) if (!(flags & FLAG_NOMAX) && maximum(elem) == 0)
snprintf(maxattr, sizeof(maxattr), "maxOccurs=\"unbounded\" "); snprintf(maxattr, sizeof(maxattr), "maxOccurs=\"unbounded\" ");
else if (!(FLAG_NOMAX) && maximum(elem) != 1) else if (!(FLAG_NOMAX) && maximum(elem) != 1)
snprintf(maxattr, sizeof(maxattr), "maxOccurs=\"%d\" ", maximum(elem)); snprintf(maxattr, sizeof(maxattr), "maxOccurs=\"%d\" ", maximum(elem));
@ -220,6 +220,7 @@ printcomplextype(
} else { } else {
assert(cnt > 1); assert(cnt > 1);
ce = firstelem(elem->children); ce = firstelem(elem->children);
assert(ce);
min[0] = min[1] = minimum(ce); min[0] = min[1] = minimum(ce);
max[0] = max[1] = maximum(ce); max[0] = max[1] = maximum(ce);
assert(min[1] <= max[1] || max[1] == 0); assert(min[1] <= max[1] || max[1] == 0);