niklas/cyclonedds
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

MPT driver incorrectly reporting a waitpid error

Browse source 
The multi-process test driver program waits until all its children have
stopped (or timeout) by calling ddsrt_proc_waitpids in a loop.  The way
the loop is written, it can try once more when all children have already
been waited for, in which case it reports a spurious error.

This fixes that problem by checking whether the error code was to be
expected.

Signed-off-by: Erik Boasson <eb@ilities.com>
This commit is contained in:
Erik Boasson 2019-05-24 08:37:19 +02:00 • committed by eboasson
parent 7fbe49c267
commit 4fc56c5cbe
1 changed files with 8 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/mpt/mpt/src/main.c.in
View file

@ -355,8 +355,14 @@ mpt_run_test(const char *exe, mpt_suite_t *suite, mpt_test_t *test)
result = EXIT_FAILURE; result = EXIT_FAILURE;
} }
} else if (retcode != DDS_RETCODE_NOT_FOUND) { } else if (retcode != DDS_RETCODE_NOT_FOUND) {
printf("Wait for processes of %s::%s failed (%d)\n", suite->name, test->name, (int)retcode); for (proc = test->procs; proc; proc = proc->next) {
result = EXIT_FAILURE; if (proc->pid != 0)
break;
}
if (proc != NULL) {
printf("Wait for processes of %s::%s failed (%d)\n", suite->name, test->name, (int)retcode);
result = EXIT_FAILURE;
}
} }
} }