niklas/cyclonedds
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

requiring checking the return value of dds_{get,set}_listener is pedantry

Browse source 
Signed-off-by: Erik Boasson <eb@ilities.com>
This commit is contained in:
Erik Boasson 2019-01-15 09:57:06 +01:00
parent 14a80978f3
commit 2e5ecb2e76
2 changed files with 4 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/core/ddsc/include/ddsc/dds.h
View file

@ -685,7 +685,7 @@ dds_set_qos(
*/ */
/* TODO: Link to (generic) Listener and status information. */ /* TODO: Link to (generic) Listener and status information. */
_Pre_satisfies_(entity & DDS_ENTITY_KIND_MASK) _Pre_satisfies_(entity & DDS_ENTITY_KIND_MASK)
DDS_EXPORT _Check_return_ dds_return_t DDS_EXPORT dds_return_t
dds_get_listener( dds_get_listener(
_In_ dds_entity_t entity, _In_ dds_entity_t entity,
_Out_ dds_listener_t * listener); _Out_ dds_listener_t * listener);
@ -744,7 +744,7 @@ dds_get_listener(
*/ */
/* TODO: Link to (generic) Listener and status information. */ /* TODO: Link to (generic) Listener and status information. */
_Pre_satisfies_(entity & DDS_ENTITY_KIND_MASK) _Pre_satisfies_(entity & DDS_ENTITY_KIND_MASK)
DDS_EXPORT _Check_return_ dds_return_t DDS_EXPORT dds_return_t
dds_set_listener( dds_set_listener(
_In_ dds_entity_t entity, _In_ dds_entity_t entity,
_In_opt_ const dds_listener_t * listener); _In_opt_ const dds_listener_t * listener);

15
src/core/ddsc/src/dds_entity.c
View file

@ -480,12 +480,7 @@ dds_get_parent(
return hdl; return hdl;
} }
dds_return_t dds_get_listener (dds_entity_t entity, dds_listener_t *listener)
_Pre_satisfies_(entity & DDS_ENTITY_KIND_MASK)
_Check_return_ dds_entity_t
dds_get_participant (
_In_ dds_entity_t entity)
{ {
dds_entity *e; dds_entity *e;
dds__retcode_t rc; dds__retcode_t rc;
@ -663,13 +658,7 @@ dds_get_listener(
return ret; return ret;
} }
dds_return_t dds_set_listener (dds_entity_t entity, const dds_listener_t *listener)
_Pre_satisfies_(entity & DDS_ENTITY_KIND_MASK)
_Check_return_ dds_return_t
dds_set_listener(
_In_ dds_entity_t entity,
_In_opt_ const dds_listener_t * listener)
{ {
dds_entity *e; dds_entity *e;
dds__retcode_t rc; dds__retcode_t rc;