niklas/cyclonedds
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Use sizeof(sin_addr) in IPv4 address compare instead of effectively sizeof(size_t)

Browse source 
Signed-off-by: Erik Boasson <eb@ilities.com>
This commit is contained in:
Erik Boasson 2018-12-30 09:59:29 +01:00 • committed by Erik Boasson
parent d6306bddbb
commit 0b814df584
2 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/core/ddsi/src/ddsi_ipaddr.c
View file

@ -38,7 +38,7 @@ int ddsi_ipaddr_compare (const os_sockaddr *const sa1, const os_sockaddr *const
sin1 = (os_sockaddr_in *)sa1; sin1 = (os_sockaddr_in *)sa1;
sin2 = (os_sockaddr_in *)sa2; sin2 = (os_sockaddr_in *)sa2;
sz = sizeof(sin1->sin_addr); sz = sizeof(sin1->sin_addr);
eq = memcmp(&sin1->sin_addr, &sin2->sin_addr, sizeof(sz)); eq = memcmp(&sin1->sin_addr, &sin2->sin_addr, sz);
break; break;
} }
default: { default: {

2
src/os/src/os_socket.c
View file

@ -142,7 +142,7 @@ static int os_sockaddr_compare(
sin1 = (os_sockaddr_in *)sa1; sin1 = (os_sockaddr_in *)sa1;
sin2 = (os_sockaddr_in *)sa2; sin2 = (os_sockaddr_in *)sa2;
sz = sizeof(sin1->sin_addr); sz = sizeof(sin1->sin_addr);
eq = memcmp(&sin1->sin_addr, &sin2->sin_addr, sizeof(sz)); eq = memcmp(&sin1->sin_addr, &sin2->sin_addr, sz);
} }
break; break;
} }