From aa4ee36aff7e22363d9cce2fd4650933a8ec1b4e Mon Sep 17 00:00:00 2001 From: Michel Hidalgo Date: Fri, 14 Aug 2020 14:05:01 -0300 Subject: [PATCH] Fix bad conditional in rmw_serialize(). (#217) Signed-off-by: Michel Hidalgo --- rmw_cyclonedds_cpp/src/rmw_node.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/rmw_cyclonedds_cpp/src/rmw_node.cpp b/rmw_cyclonedds_cpp/src/rmw_node.cpp index ff0b6ea..f83e58e 100644 --- a/rmw_cyclonedds_cpp/src/rmw_node.cpp +++ b/rmw_cyclonedds_cpp/src/rmw_node.cpp @@ -1388,13 +1388,13 @@ extern "C" rmw_ret_t rmw_serialize( const rosidl_message_type_support_t * type_support, rmw_serialized_message_t * serialized_message) { - rmw_ret_t ret; try { auto writer = rmw_cyclonedds_cpp::make_cdr_writer( rmw_cyclonedds_cpp::make_message_value_type(type_support)); auto size = writer->get_serialized_size(ros_message); - if ((ret = rmw_serialized_message_resize(serialized_message, size) != RMW_RET_OK)) { + rmw_ret_t ret = rmw_serialized_message_resize(serialized_message, size); + if (RMW_RET_OK != ret) { RMW_SET_ERROR_MSG("rmw_serialize: failed to allocate space for message"); return ret; }