diff --git a/rclcpp/include/rclcpp/client.hpp b/rclcpp/include/rclcpp/client.hpp index 3d27cb8..ad176df 100644 --- a/rclcpp/include/rclcpp/client.hpp +++ b/rclcpp/include/rclcpp/client.hpp @@ -58,9 +58,9 @@ public: get_client_handle() const; virtual std::shared_ptr create_response() = 0; - virtual std::shared_ptr create_request_header() = 0; + virtual std::shared_ptr create_request_header() = 0; virtual void handle_response( - std::shared_ptr request_header, std::shared_ptr response) = 0; + std::shared_ptr request_header, std::shared_ptr response) = 0; private: RCLCPP_DISABLE_COPY(ClientBase); @@ -104,19 +104,19 @@ public: return std::shared_ptr(new typename ServiceT::Response()); } - std::shared_ptr create_request_header() + std::shared_ptr create_request_header() { // TODO(wjwwood): This should probably use rmw_request_id's allocator. // (since it is a C type) - return std::shared_ptr(new rmw_request_id_t); + return std::shared_ptr(new rmw_request_id_t); } - void handle_response(std::shared_ptr request_header, std::shared_ptr response) + void handle_response(std::shared_ptr request_header, + std::shared_ptr response) { std::lock_guard lock(pending_requests_mutex_); - auto typed_request_header = std::static_pointer_cast(request_header); auto typed_response = std::static_pointer_cast(response); - int64_t sequence_number = typed_request_header->sequence_number; + int64_t sequence_number = request_header->sequence_number; // TODO(esteve) this should throw instead since it is not expected to happen in the first place if (this->pending_requests_.count(sequence_number) == 0) { fprintf(stderr, "Received invalid sequence number. Ignoring...\n"); diff --git a/rclcpp/include/rclcpp/service.hpp b/rclcpp/include/rclcpp/service.hpp index 84c2c99..b267cbc 100644 --- a/rclcpp/include/rclcpp/service.hpp +++ b/rclcpp/include/rclcpp/service.hpp @@ -55,9 +55,9 @@ public: get_service_handle(); virtual std::shared_ptr create_request() = 0; - virtual std::shared_ptr create_request_header() = 0; + virtual std::shared_ptr create_request_header() = 0; virtual void handle_request( - std::shared_ptr request_header, + std::shared_ptr request_header, std::shared_ptr request) = 0; private: @@ -102,20 +102,20 @@ public: return std::shared_ptr(new typename ServiceT::Request()); } - std::shared_ptr create_request_header() + std::shared_ptr create_request_header() { // TODO(wjwwood): This should probably use rmw_request_id's allocator. // (since it is a C type) - return std::shared_ptr(new rmw_request_id_t); + return std::shared_ptr(new rmw_request_id_t); } - void handle_request(std::shared_ptr request_header, std::shared_ptr request) + void handle_request(std::shared_ptr request_header, + std::shared_ptr request) { auto typed_request = std::static_pointer_cast(request); - auto typed_request_header = std::static_pointer_cast(request_header); auto response = std::shared_ptr(new typename ServiceT::Response); - any_callback_.dispatch(typed_request_header, typed_request, response); - send_response(typed_request_header, response); + any_callback_.dispatch(request_header, typed_request, response); + send_response(request_header, response); } void send_response( diff --git a/rclcpp/src/rclcpp/executor.cpp b/rclcpp/src/rclcpp/executor.cpp index 16a1ea8..3be7e7d 100644 --- a/rclcpp/src/rclcpp/executor.cpp +++ b/rclcpp/src/rclcpp/executor.cpp @@ -287,7 +287,7 @@ void Executor::execute_service( rclcpp::service::ServiceBase::SharedPtr service) { - std::shared_ptr request_header = service->create_request_header(); + auto request_header = service->create_request_header(); std::shared_ptr request = service->create_request(); bool taken = false; rmw_ret_t status = rmw_take_request( @@ -310,7 +310,7 @@ void Executor::execute_client( rclcpp::client::ClientBase::SharedPtr client) { - std::shared_ptr request_header = client->create_request_header(); + auto request_header = client->create_request_header(); std::shared_ptr response = client->create_response(); bool taken = false; rmw_ret_t status = rmw_take_response(