From f6c2f5ba0d12968e38d340c1857a766093e42ee1 Mon Sep 17 00:00:00 2001 From: Mikael Arguedas Date: Tue, 18 Sep 2018 15:42:00 -0700 Subject: [PATCH] use add_compile_options instead of setting only cxx flags --- rclcpp/CMakeLists.txt | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/rclcpp/CMakeLists.txt b/rclcpp/CMakeLists.txt index 5f549ba..3d8f697 100644 --- a/rclcpp/CMakeLists.txt +++ b/rclcpp/CMakeLists.txt @@ -19,12 +19,7 @@ if(NOT CMAKE_CXX_STANDARD) set(CMAKE_CXX_STANDARD 14) endif() if(CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES "Clang") - # we dont use add_compile_options with pedantic in message packages - # because the Python C extensions dont comply with it - # TODO(mikaelarguedas) change to add_compile_options - # once this is not a message package anymore - # https://github.com/ros2/system_tests/issues/191 - set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Wextra -Wpedantic") + add_compile_options(-Wall -Wextra -Wpedantic) endif() include_directories(include)