diff --git a/rclcpp/include/rclcpp/node.hpp b/rclcpp/include/rclcpp/node.hpp index 53bc208..dcc91bd 100644 --- a/rclcpp/include/rclcpp/node.hpp +++ b/rclcpp/include/rclcpp/node.hpp @@ -29,8 +29,6 @@ #include #include -#include - namespace rclcpp { @@ -104,7 +102,6 @@ public: create_service( std::string service_name, std::function &, - const std::shared_ptr &, std::shared_ptr&)> callback, rclcpp::callback_group::CallbackGroup::SharedPtr group=nullptr); diff --git a/rclcpp/include/rclcpp/node_impl.hpp b/rclcpp/include/rclcpp/node_impl.hpp index 5f9c3b2..002360f 100644 --- a/rclcpp/include/rclcpp/node_impl.hpp +++ b/rclcpp/include/rclcpp/node_impl.hpp @@ -188,7 +188,6 @@ typename service::Service::SharedPtr Node::create_service( std::string service_name, std::function &, - const std::shared_ptr &, std::shared_ptr&)> callback, rclcpp::callback_group::CallbackGroup::SharedPtr group) { diff --git a/rclcpp/include/rclcpp/service.hpp b/rclcpp/include/rclcpp/service.hpp index 2e85fe3..04d644e 100644 --- a/rclcpp/include/rclcpp/service.hpp +++ b/rclcpp/include/rclcpp/service.hpp @@ -20,10 +20,10 @@ #include #include +#include #include -#include namespace rclcpp { @@ -74,7 +74,6 @@ class Service : public ServiceBase public: typedef std::function< void(const std::shared_ptr &, - const std::shared_ptr &, std::shared_ptr&)> CallbackType; RCLCPP_MAKE_SHARED_DEFINITIONS(Service); @@ -92,20 +91,20 @@ public: std::shared_ptr create_request_header() { - return std::shared_ptr(new userland_msgs::RequestId()); + return std::shared_ptr(new ros_middleware_interface::RequestId()); } void handle_request(std::shared_ptr &request, std::shared_ptr &req_id) { auto typed_request = std::static_pointer_cast(request); - auto typed_req_id = std::static_pointer_cast(req_id); + auto typed_req_id = std::static_pointer_cast(req_id); auto response = std::shared_ptr(new typename ServiceT::Response); - callback_(typed_request, typed_req_id, response); + callback_(typed_request, response); send_response(typed_req_id, response); } void send_response( - std::shared_ptr &req_id, + std::shared_ptr &req_id, std::shared_ptr &response) { ::ros_middleware_interface::send_response(get_service_handle(), req_id.get(), response.get());