diff --git a/rclcpp/include/rclcpp/serialization.hpp b/rclcpp/include/rclcpp/serialization.hpp index 53fe59d..97d0449 100644 --- a/rclcpp/include/rclcpp/serialization.hpp +++ b/rclcpp/include/rclcpp/serialization.hpp @@ -39,10 +39,6 @@ template struct is_serialized_message_class : std::false_type {}; -template<> -struct is_serialized_message_class: std::true_type -{}; - template<> struct is_serialized_message_class: std::true_type {}; diff --git a/rclcpp/include/rclcpp/subscription_traits.hpp b/rclcpp/include/rclcpp/subscription_traits.hpp index 3a84764..8eacd3a 100644 --- a/rclcpp/include/rclcpp/subscription_traits.hpp +++ b/rclcpp/include/rclcpp/subscription_traits.hpp @@ -42,15 +42,6 @@ template struct is_serialized_subscription_argument : std::false_type {}; -template<> -struct is_serialized_subscription_argument: std::true_type -{}; - -template<> -struct is_serialized_subscription_argument> - : std::true_type -{}; - template<> struct is_serialized_subscription_argument: std::true_type {}; diff --git a/rclcpp/test/test_subscription_traits.cpp b/rclcpp/test/test_subscription_traits.cpp index c99f25b..c7b062a 100644 --- a/rclcpp/test/test_subscription_traits.cpp +++ b/rclcpp/test/test_subscription_traits.cpp @@ -67,13 +67,13 @@ TEST(TestSubscriptionTraits, is_serialized_callback) { // Test regular functions auto cb1 = &serialized_callback_copy; static_assert( - rclcpp::subscription_traits::is_serialized_callback::value == true, - "rcl_serialized_message_t in a first argument callback makes it a serialized callback"); + rclcpp::subscription_traits::is_serialized_callback::value == false, + "passing a rcl_serialized_message_t * is not a serialized callback"); auto cb2 = &serialized_callback_shared_ptr; static_assert( - rclcpp::subscription_traits::is_serialized_callback::value == true, - "std::shared_ptr in a callback makes it a serialized callback"); + rclcpp::subscription_traits::is_serialized_callback::value == false, + "passing a std::shared_ptr is not a serialized callback"); auto cb3 = ¬_serialized_callback; static_assert( @@ -90,8 +90,8 @@ TEST(TestSubscriptionTraits, is_serialized_callback) { (void) unused; }; static_assert( - rclcpp::subscription_traits::is_serialized_callback::value == true, - "rcl_serialized_message_t in a first argument callback makes it a serialized callback"); + rclcpp::subscription_traits::is_serialized_callback::value == false, + "passing rcl_serialized_message_t is not a serialized callback"); using MessageT = test_msgs::msg::Empty; using MessageTAllocator = std::allocator;