diff --git a/rclcpp/include/rclcpp/client.hpp b/rclcpp/include/rclcpp/client.hpp index 0c33420..eef1264 100644 --- a/rclcpp/include/rclcpp/client.hpp +++ b/rclcpp/include/rclcpp/client.hpp @@ -67,7 +67,8 @@ public: virtual std::shared_ptr create_response() = 0; virtual std::shared_ptr create_request_header() = 0; - virtual void handle_response(std::shared_ptr &response, std::shared_ptr &req_id) = 0; + virtual void handle_response(std::shared_ptr &request_header, + std::shared_ptr &response) = 0; private: RCLCPP_DISABLE_COPY(ClientBase); @@ -106,11 +107,11 @@ public: return std::shared_ptr(new rmw_request_id_t); } - void handle_response(std::shared_ptr &response, std::shared_ptr &req_id) + void handle_response(std::shared_ptr &request_header, std::shared_ptr &response) { - auto typed_req_id = std::static_pointer_cast(req_id); + auto typed_request_header = std::static_pointer_cast(request_header); auto typed_response = std::static_pointer_cast(response); - int64_t sequence_number = typed_req_id->sequence_number; + int64_t sequence_number = typed_request_header->sequence_number; auto tuple = this->pending_requests_[sequence_number]; auto call_promise = std::get<0>(tuple); auto callback = std::get<1>(tuple); diff --git a/rclcpp/include/rclcpp/executor.hpp b/rclcpp/include/rclcpp/executor.hpp index 3b229d9..2370825 100644 --- a/rclcpp/include/rclcpp/executor.hpp +++ b/rclcpp/include/rclcpp/executor.hpp @@ -176,16 +176,16 @@ protected: execute_service( rclcpp::service::ServiceBase::SharedPtr &service) { - std::shared_ptr request = service->create_request(); std::shared_ptr request_header = service->create_request_header(); + std::shared_ptr request = service->create_request(); bool taken = false; rmw_take_request(service->service_handle_, - request.get(), request_header.get(), + request.get(), &taken); if (taken) { - service->handle_request(request, request_header); + service->handle_request(request_header, request); } else { @@ -199,16 +199,16 @@ protected: execute_client( rclcpp::client::ClientBase::SharedPtr &client) { - std::shared_ptr response = client->create_response(); std::shared_ptr request_header = client->create_request_header(); + std::shared_ptr response = client->create_response(); bool taken = false; - taken = rmw_take_response(client->client_handle_, - response.get(), - request_header.get(), - &taken); + rmw_take_response(client->client_handle_, + request_header.get(), + response.get(), + &taken); if (taken) { - client->handle_response(response, request_header); + client->handle_response(request_header, response); } else { diff --git a/rclcpp/include/rclcpp/service.hpp b/rclcpp/include/rclcpp/service.hpp index a279566..3cb4c1f 100644 --- a/rclcpp/include/rclcpp/service.hpp +++ b/rclcpp/include/rclcpp/service.hpp @@ -66,7 +66,8 @@ public: virtual std::shared_ptr create_request() = 0; virtual std::shared_ptr create_request_header() = 0; - virtual void handle_request(std::shared_ptr &request, std::shared_ptr &req_id) = 0; + virtual void handle_request(std::shared_ptr &request_header, + std::shared_ptr &request) = 0; private: RCLCPP_DISABLE_COPY(ServiceBase); @@ -103,13 +104,13 @@ public: return std::shared_ptr(new rmw_request_id_t); } - void handle_request(std::shared_ptr &request, std::shared_ptr &req_id) + void handle_request(std::shared_ptr &request_header, std::shared_ptr &request) { auto typed_request = std::static_pointer_cast(request); - auto typed_req_id = std::static_pointer_cast(req_id); + auto typed_request_header = std::static_pointer_cast(request_header); auto response = std::shared_ptr(new typename ServiceT::Response); callback_(typed_request, response); - send_response(typed_req_id, response); + send_response(typed_request_header, response); } void send_response(std::shared_ptr &req_id,