From 6b6b94faa2436e891353e9a9c7f13c9d0f607300 Mon Sep 17 00:00:00 2001 From: Esteve Fernandez Date: Tue, 28 Apr 2015 11:31:12 -0700 Subject: [PATCH] Added comment about not being able to call spin_node_until_future_complete inside a callback executed by an executor --- rclcpp/include/rclcpp/executors.hpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/rclcpp/include/rclcpp/executors.hpp b/rclcpp/include/rclcpp/executors.hpp index cc965ef..ff3b463 100644 --- a/rclcpp/include/rclcpp/executors.hpp +++ b/rclcpp/include/rclcpp/executors.hpp @@ -36,6 +36,8 @@ spin_node_until_future_complete( std::shared_future & future) { std::future_status status; + // TODO: does not work recursively right, can't call spin_node_until_future_complete + // inside a callback executed by an executor. do { executor.spin_node_some(node_ptr); status = future.wait_for(std::chrono::seconds(0));