diff --git a/rclcpp/include/rclcpp/parameter_service.hpp b/rclcpp/include/rclcpp/parameter_service.hpp index 95d2b0d..953c4c2 100644 --- a/rclcpp/include/rclcpp/parameter_service.hpp +++ b/rclcpp/include/rclcpp/parameter_service.hpp @@ -47,7 +47,7 @@ public: : node_(node) { get_parameters_service_ = node_->create_service( - node_->get_name() + "__get_parameters", [&node]( + node_->get_name() + "__get_parameters", [node]( const std::shared_ptr, const std::shared_ptr request, std::shared_ptr response) @@ -60,7 +60,7 @@ public: ); get_parameter_types_service_ = node_->create_service( - node_->get_name() + "__get_parameter_types", [&node]( + node_->get_name() + "__get_parameter_types", [node]( const std::shared_ptr, const std::shared_ptr request, std::shared_ptr response) @@ -74,7 +74,7 @@ public: ); set_parameters_service_ = node_->create_service( - node_->get_name() + "__set_parameters", [&node]( + node_->get_name() + "__set_parameters", [node]( const std::shared_ptr, const std::shared_ptr request, std::shared_ptr response) @@ -90,7 +90,7 @@ public: set_parameters_atomically_service_ = node_->create_service( - node_->get_name() + "__set_parameters_atomically", [&node]( + node_->get_name() + "__set_parameters_atomically", [node]( const std::shared_ptr, const std::shared_ptr request, std::shared_ptr response) @@ -108,7 +108,7 @@ public: ); describe_parameters_service_ = node_->create_service( - node_->get_name() + "__describe_parameters", [&node]( + node_->get_name() + "__describe_parameters", [node]( const std::shared_ptr, const std::shared_ptr request, std::shared_ptr response) @@ -119,7 +119,7 @@ public: ); list_parameters_service_ = node_->create_service( - node_->get_name() + "__list_parameters", [&node]( + node_->get_name() + "__list_parameters", [node]( const std::shared_ptr, const std::shared_ptr request, std::shared_ptr response) diff --git a/rclcpp/include/rclcpp/service.hpp b/rclcpp/include/rclcpp/service.hpp index 4726b76..1ef76f2 100644 --- a/rclcpp/include/rclcpp/service.hpp +++ b/rclcpp/include/rclcpp/service.hpp @@ -78,8 +78,8 @@ public: virtual std::shared_ptr create_request() = 0; virtual std::shared_ptr create_request_header() = 0; virtual void handle_request( - std::shared_ptr & request_header, - std::shared_ptr & request) = 0; + std::shared_ptr request_header, + std::shared_ptr request) = 0; private: RCLCPP_DISABLE_COPY(ServiceBase); @@ -97,14 +97,14 @@ class Service : public ServiceBase public: using CallbackType = std::function< void( - const std::shared_ptr &, - std::shared_ptr &)>; + const std::shared_ptr, + std::shared_ptr)>; using CallbackWithHeaderType = std::function< void( - const std::shared_ptr &, - const std::shared_ptr &, - std::shared_ptr &)>; + const std::shared_ptr, + const std::shared_ptr, + std::shared_ptr)>; RCLCPP_SMART_PTR_DEFINITIONS(Service); Service( @@ -137,7 +137,7 @@ public: return std::shared_ptr(new rmw_request_id_t); } - void handle_request(std::shared_ptr & request_header, std::shared_ptr & request) + void handle_request(std::shared_ptr request_header, std::shared_ptr request) { auto typed_request = std::static_pointer_cast(request); auto typed_request_header = std::static_pointer_cast(request_header); @@ -151,8 +151,8 @@ public: } void send_response( - std::shared_ptr & req_id, - std::shared_ptr & response) + std::shared_ptr req_id, + std::shared_ptr response) { rmw_ret_t status = rmw_send_response(get_service_handle(), req_id.get(), response.get()); if (status != RMW_RET_OK) {