From 286084b05e18aad68fec80846538344f07c4f37d Mon Sep 17 00:00:00 2001 From: Esteve Fernandez Date: Mon, 1 Jun 2015 15:27:55 -0700 Subject: [PATCH] Fix warning about comparison between signed and unsigned integers --- rclcpp/include/rclcpp/node_impl.hpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/rclcpp/include/rclcpp/node_impl.hpp b/rclcpp/include/rclcpp/node_impl.hpp index 185fd89..770d1c6 100644 --- a/rclcpp/include/rclcpp/node_impl.hpp +++ b/rclcpp/include/rclcpp/node_impl.hpp @@ -309,13 +309,14 @@ Node::list_parameters( std::lock_guard lock(mutex_); rcl_interfaces::ListParametersResult result; - // TODO: define parameter separator, use "." for now + // TODO(esteve): define parameter separator, use "." for now for (auto & kv : parameters_) { if (std::any_of(prefixes.cbegin(), prefixes.cend(), [&kv, &depth](const std::string & prefix) { if (kv.first.find(prefix + ".") == 0) { size_t length = prefix.length(); std::string substr = kv.first.substr(length); - return std::count(substr.begin(), substr.end(), '.') < depth; + // Cast as unsigned integer to avoid warning + return static_cast(std::count(substr.begin(), substr.end(), '.')) < depth; } return false; }))