From 481d58bb6e4c74b7462042ae0aab8f96ec4e8aae Mon Sep 17 00:00:00 2001 From: Jackie Kay Date: Tue, 24 Nov 2015 10:04:26 -0800 Subject: [PATCH] Fix cpplint and windows build --- rclcpp/include/rclcpp/node.hpp | 1 - rclcpp/include/rclcpp/timer.hpp | 3 +-- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/rclcpp/include/rclcpp/node.hpp b/rclcpp/include/rclcpp/node.hpp index b027695..78d15b8 100644 --- a/rclcpp/include/rclcpp/node.hpp +++ b/rclcpp/include/rclcpp/node.hpp @@ -172,7 +172,6 @@ public: * \param[in] group Callback group to execute this timer's callback in. */ template - RCLCPP_PUBLIC typename rclcpp::timer::WallTimer::SharedPtr create_wall_timer( std::chrono::nanoseconds period, diff --git a/rclcpp/include/rclcpp/timer.hpp b/rclcpp/include/rclcpp/timer.hpp index 131edf7..ea29396 100644 --- a/rclcpp/include/rclcpp/timer.hpp +++ b/rclcpp/include/rclcpp/timer.hpp @@ -41,7 +41,7 @@ public: RCLCPP_SMART_PTR_DEFINITIONS_NOT_COPYABLE(TimerBase); RCLCPP_PUBLIC - TimerBase(std::chrono::nanoseconds period); + explicit TimerBase(std::chrono::nanoseconds period); RCLCPP_PUBLIC virtual ~TimerBase(); @@ -142,7 +142,6 @@ public: void execute_callback_delegate() { - //callback_(std::move(std::shared_ptr(this))); callback_(*this); }