From bad0f554160115531ca932658dc9c9adb4d48e01 Mon Sep 17 00:00:00 2001 From: Dirk Thomas Date: Thu, 22 Mar 2018 16:26:33 -0700 Subject: [PATCH] change export order for static linking (#216) --- rcl/CMakeLists.txt | 17 +++++++++-------- rcl_lifecycle/CMakeLists.txt | 10 +++++++--- 2 files changed, 16 insertions(+), 11 deletions(-) diff --git a/rcl/CMakeLists.txt b/rcl/CMakeLists.txt index f253ed2..980e8bd 100644 --- a/rcl/CMakeLists.txt +++ b/rcl/CMakeLists.txt @@ -47,11 +47,12 @@ set(${PROJECT_NAME}_sources ) add_library(${PROJECT_NAME} ${${PROJECT_NAME}_sources}) +# specific order: dependents before dependencies ament_target_dependencies(${PROJECT_NAME} "rcl_interfaces" - "rcutils" - "rmw" "rmw_implementation" + "rmw" + "rcutils" "rosidl_generator_c" ) @@ -71,17 +72,17 @@ install( # This is overwritten each loop, but which one it points to doesn't really matter. set(rcl_lib_dir "$") +# specific order: dependents before dependencies +ament_export_include_directories(include) +ament_export_libraries(${PROJECT_NAME}) + ament_export_dependencies(ament_cmake) ament_export_dependencies(rcl_interfaces) -ament_export_dependencies(rcutils) -ament_export_dependencies(rmw) ament_export_dependencies(rmw_implementation) +ament_export_dependencies(rmw) +ament_export_dependencies(rcutils) ament_export_dependencies(rosidl_generator_c) -ament_export_include_directories(include) - -ament_export_libraries(${PROJECT_NAME}) - if(BUILD_TESTING) find_package(ament_lint_auto REQUIRED) ament_lint_auto_find_test_dependencies() diff --git a/rcl_lifecycle/CMakeLists.txt b/rcl_lifecycle/CMakeLists.txt index f9cb0ae..4977da5 100644 --- a/rcl_lifecycle/CMakeLists.txt +++ b/rcl_lifecycle/CMakeLists.txt @@ -40,9 +40,10 @@ add_library( rcl_lifecycle ${rcl_lifecycle_sources}) +# specific order: dependents before dependencies ament_target_dependencies(rcl_lifecycle - "lifecycle_msgs" "rcl" + "lifecycle_msgs" "rcutils" ) @@ -94,10 +95,13 @@ if(BUILD_TESTING) endif() endif() -ament_export_dependencies(ament_cmake) -ament_export_dependencies(lifecycle_msgs) +# specific order: dependents before dependencies ament_export_include_directories(include) ament_export_libraries(${PROJECT_NAME}) +ament_export_dependencies(ament_cmake) +ament_export_dependencies(rcl) +ament_export_dependencies(lifecycle_msgs) +ament_export_dependencies(rcutils) ament_package() install(