From 2079097227002308b4b0e2a027b555a6a117512d Mon Sep 17 00:00:00 2001 From: Ethan Gao <16472154+gaoethan@users.noreply.github.com> Date: Fri, 17 Nov 2017 04:41:33 +0800 Subject: [PATCH] optimize to avoid potential issue from uninitialized scalar variable (#183) Signed-off-by: Ethan Gao --- rcl_lifecycle/src/com_interface.c | 1 + rcl_lifecycle/src/rcl_lifecycle.c | 1 + 2 files changed, 2 insertions(+) diff --git a/rcl_lifecycle/src/com_interface.c b/rcl_lifecycle/src/com_interface.c index dc75d00..6b21d12 100644 --- a/rcl_lifecycle/src/com_interface.c +++ b/rcl_lifecycle/src/com_interface.c @@ -67,6 +67,7 @@ rcl_lifecycle_com_interface_t rcl_lifecycle_get_zero_initialized_com_interface() { rcl_lifecycle_com_interface_t com_interface; + com_interface.node_handle = NULL; com_interface.pub_transition_event = rcl_get_zero_initialized_publisher(); com_interface.srv_change_state = rcl_get_zero_initialized_service(); com_interface.srv_get_state = rcl_get_zero_initialized_service(); diff --git a/rcl_lifecycle/src/rcl_lifecycle.c b/rcl_lifecycle/src/rcl_lifecycle.c index 6ffb79c..afeec51 100644 --- a/rcl_lifecycle/src/rcl_lifecycle.c +++ b/rcl_lifecycle/src/rcl_lifecycle.c @@ -38,6 +38,7 @@ rcl_lifecycle_state_machine_t rcl_lifecycle_get_zero_initialized_state_machine() { rcl_lifecycle_state_machine_t state_machine; + state_machine.current_state = NULL; state_machine.transition_map = rcl_lifecycle_get_zero_initialized_transition_map(); state_machine.com_interface = rcl_lifecycle_get_zero_initialized_com_interface(); return state_machine;